Skip to content

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 1, 2021

Part of #85153

r? @Aaron1011

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 1, 2021

Let's be prudent this time.
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Collaborator

bors commented Jun 1, 2021

⌛ Trying commit 28afaee with merge a827ab0b3992d7da21121ac2d8c501959f393a8c...

@bors
Copy link
Collaborator

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: a827ab0b3992d7da21121ac2d8c501959f393a8c (a827ab0b3992d7da21121ac2d8c501959f393a8c)

@rust-timer
Copy link
Collaborator

Queued a827ab0b3992d7da21121ac2d8c501959f393a8c with parent 7f9ab03, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (a827ab0b3992d7da21121ac2d8c501959f393a8c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 2, 2021
@Aaron1011
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 2, 2021

📌 Commit 28afaee has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2021
@bors
Copy link
Collaborator

bors commented Jun 2, 2021

⌛ Testing commit 28afaee with merge 7350f65...

@bors
Copy link
Collaborator

bors commented Jun 2, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 7350f65 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2021
@bors bors merged commit 7350f65 into rust-lang:master Jun 2, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 2, 2021
@cjgillot cjgillot deleted the private-dep-query branch June 2, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants